Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-66 🔀 회원가입 페이지 머지 요청 #72

Merged
merged 37 commits into from
Jul 30, 2024
Merged

Conversation

jangmoonwon
Copy link
Contributor

@jangmoonwon jangmoonwon commented Jul 25, 2024

🔖 Issue Ticket

Ticket

✍️ Description

회원가입 페이지를 메인 페이지에 머지 요청

✅ Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

Additional Notes

  • 간편 로그인(구글, 카카오톡, 네이버)
  • 간편 회원가입 페이지
  • 7/26 코드리뷰 내용(mutation hook 에러처리) 수정하기

jangmoonwon and others added 25 commits July 17, 2024 21:34
FE-67 💄 회원가입 페이지 ui 및 반응형 디자인 제작
FE-68 ✨ 회원가입 페이지 유효성 검사
FE-66 🔧 회원가입 페이지 ui 수정
FE-66 🔀 epic브랜치 최신화
FE-69 ♻️ mutation hook 에러처리 변경
FE-66 ✨ 회원가입 페이지 api
@jangmoonwon jangmoonwon requested a review from kich555 July 25, 2024 02:15
@jangmoonwon jangmoonwon self-assigned this Jul 25, 2024
kich555
kich555 previously approved these changes Jul 25, 2024
src/hooks/useRegisterMutation.ts Outdated Show resolved Hide resolved
@jangmoonwon jangmoonwon requested a review from kich555 July 28, 2024 22:31
router.push('/');
},
onError: (error) => {
if (isAxiosError(error)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  if (!isAxiosError(error)) return;

if (isAxiosError(error)) {
const { status, data } = error.response || {};

if (!status) return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jangmoonwon jangmoonwon merged commit 9daf9fe into main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High 🔥 우선순위 높음 Type: Merge 🚚 머지
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants